New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: Populate mount options when running "list" #14293

Merged
1 commit merged into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
@badone
Contributor

badone commented Apr 3, 2017

Also tidy up by moving duplicated code into a function

Fixes: http://tracker.ceph.com/issues/17331
Signed-off-by: Brad Hubbard bhubbard@redhat.com

@badone badone requested a review from Apr 3, 2017

@badone

This comment has been minimized.

Contributor

badone commented Apr 4, 2017

/me discovers flake8

ceph-disk: Populate mount options when running "list"
Also tidy up by moving duplicated code into a function

Fixes: http://tracker.ceph.com/issues/17331
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone

This comment has been minimized.

Contributor

badone commented Apr 5, 2017

@dachary mind taking a look mate?

@yuriw

This comment has been minimized.

Contributor

yuriw commented Apr 5, 2017

@badone this one can be merged

@ghost

This comment has been minimized.

ghost commented Apr 5, 2017

@badone nicely done :-) It needs a run of the ceph-disk suite and then it's all good.

@ghost

This comment has been minimized.

ghost commented Apr 5, 2017

@yuriw would you do the honor ?

@yuriw

This comment has been minimized.

@ghost

ghost approved these changes Apr 6, 2017

@ghost ghost merged commit 81527f2 into ceph:master Apr 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@badone badone deleted the badone:wip-ceph-disk-list-selinux branch Apr 6, 2017

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment