New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/rdma: Make port number an attribute of the Connection not o… #14297

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
4 participants
@Adirl

Adirl commented Apr 3, 2017

…f the Device

Since multiple connections on different ports could exist, shouldn't use
device->active_port, instead use conn->ibport.
Or in other words, now Device object doesn't have an active_port,
instead every port specific action (create_qp, get_lid, get_gid etc.)
need to specify the port number. The information about the port number
is known to the connection (RDMAConnectedSocket*) who is the caller of
those actions.

Signed-off-by: Amir Vadai amir@vadai.me

@Adirl

This comment has been minimized.

Adirl commented Apr 3, 2017

@@ -82,6 +86,8 @@ class Device {
EventCallbackRef async_handler;
Infiniband *infiniband;
void verify_port(CephContext *c, int port_num);

This comment has been minimized.

@yuyuyu101

yuyuyu101 Apr 3, 2017

Member

we don't need to pass CephContext in, Device already has CephContext member

This comment has been minimized.

@amirv

amirv Apr 4, 2017

Contributor

ack. good catch

@liewegas liewegas added the rdma label Apr 3, 2017

msg/async/rdma: Make port number an attribute of the Connection not o…
…f the Device

Since multiple connections on different ports could exist, shouldn't use
device->active_port, instead use conn->ibport.
Or in other words, now Device object doesn't have an active_port,
instead every port specific action (create_qp, get_lid, get_gid etc.)
need to specify the port number. The information about the port number
is known to the connection (RDMAConnectedSocket*) who is the caller of
those actions.

Issue: 995322
Change-Id: I482cb87c04ba99845dc44f6dd0547835fe814ebf
Signed-off-by: Amir Vadai <amir@vadai.me>
@Adirl

This comment has been minimized.

Adirl commented Apr 4, 2017

@yuyuyu101
Done

@yuyuyu101 yuyuyu101 merged commit 71c78b8 into ceph:master Apr 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment