Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/SyntheticClient.cc: Fix warning in random_walk #14308

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@badone
Copy link
Contributor

badone commented Apr 4, 2017

Signed-off-by: Brad Hubbard bhubbard@redhat.com

@badone badone requested a review from liewegas Apr 4, 2017

@badone

This comment has been minimized.

Copy link
Contributor Author

badone commented Apr 4, 2017

@liewegas could you take a look at this? The multiplication of a bool value generates a compiler warning and seems to serve no purpose since precedence shakes out like this?

(.9*(roll_die(::pow(((double).9),((double)((cwd.depth)())))))) && (!((subdirs.empty)()))

client/SyntheticClient.cc: Fix warning in random_walk
Fixes: http://tracker.ceph.com/issues/19445
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

@badone badone force-pushed the badone:SyntheticClient_random_walk_warning branch from 5746e34 to b05bc81 Apr 4, 2017

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Apr 5, 2017

@badone heh i have no memory of this code.. and expect it isn't ever run by our current test suite. trust your judgement here!

@yuriw yuriw merged commit 618767b into ceph:master Apr 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.