New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/simple_spin: use __ppc_yield() on all powerpc archs #14310

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Apr 4, 2017

__ppc_yield() is declared in sys/platform/ppc.h by glibc, for better
portability we just use the inlined assembly here. the shared resource
hints are supported by PowerPC ISA 2.06 but on older PowerPC cores, they
are no-ops. so it's fine to do this way.

Signed-off-by: Kefu Chai kchai@redhat.com

common/simple_spin: use __ppc_yield() on all powerpc archs
__ppc_yield() is declared in sys/platform/ppc.h by glibc, for better
portability we just use the inlined assembly here. the shared resource
hints are supported by PowerPC ISA 2.06 but on older PowerPC cores, they
are no-ops. so it's fine to do this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from badone Apr 4, 2017

@badone

badone approved these changes Apr 4, 2017

LGTM, thanks for following up on this.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 4, 2017

@kestrels the first build failure you mentioned in #14289 is addressed here.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 4, 2017

@kestrels could you please give it a try? if it builds in your testbed, i will merge it.

@kestrels

This comment has been minimized.

Contributor

kestrels commented Apr 4, 2017

Sure thing. The build is running now.

@kestrels

This comment has been minimized.

Contributor

kestrels commented Apr 4, 2017

With both #14289 and #14310, the build completed successfully. The unittest_crc32c confirmed that the ppc specific crc algorithm is being used.

@tchaikov tchaikov merged commit c0e044c into ceph:master Apr 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-yield-for-ppc branch Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment