New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: build tracepoint libraries for vstart target #14354

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
@mogeb
Contributor

mogeb commented Apr 5, 2017

Avoid a segfault in TracepointProvider::verify_config() when building
for the 'vstart' target. TracepointProvider tries to load the tracepoint
providers libraries at runtime, but these aren't built as part of the
'vstart' target.

Signed-off-by: Mohamad Gebai mgebai@suse.com

add_dependencies(vstart os_tp)
add_dependencies(vstart osd_tp)
add_dependencies(vstart rbd_tp)
endif(WITH_LTTNG)

This comment has been minimized.

@cbodley

cbodley Apr 5, 2017

Contributor

does it work if you put these in tracing/CMakeLists.txt instead? that would make it easier to keep these dependencies up-to-date if we add more tracing libraries in the future

This comment has been minimized.

@mogeb

mogeb Apr 6, 2017

Contributor

Good point. AFAIK, I can't add a dependency directly on vstart in tracing/CMakeLists.txt due to the cmake structure, so I used a dependency indirection using tracepoint_libraries.

cmake: build tracepoint libraries for vstart target
Avoid a segfault in TracepointProvider::verify_config() when building
for the 'vstart' target. TracepointProvider tries to load the tracepoint
providers libraries at runtime, but these aren't built as part of the
'vstart' target.

Signed-off-by: Mohamad Gebai <mgebai@suse.com>
@cbodley

cbodley approved these changes Apr 6, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 6, 2017

is there a tracker issue for that segfault? it sounds like we want to fix that, too

@cbodley cbodley added the build/ops label Apr 6, 2017

@cbodley cbodley self-assigned this Apr 6, 2017

@mogeb

This comment has been minimized.

Contributor

mogeb commented Apr 6, 2017

Thank you for reviewing - No, I don't believe there is one (just did a quick search).

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 6, 2017

@mogeb could you create one please, and include the stack trace of the segfault? if you have trouble creating a ticket, you can paste the stack trace here and i'll make one

@mogeb

This comment has been minimized.

Contributor

mogeb commented Apr 6, 2017

@cbodley Done: http://tracker.ceph.com/issues/19522 - I didn't know if I should open it as a bug or a fix.

@cbodley cbodley merged commit 8089276 into ceph:master Apr 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@mogeb mogeb deleted the mogeb:cmake-lttng branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment