New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/Finisher: batch handle perfcounter && only send signal when waiter existed. #14363

Merged
merged 3 commits into from May 4, 2017

Conversation

Projects
None yet
2 participants
@majianpeng
Member

majianpeng commented Apr 6, 2017

No description provided.

@liewegas liewegas changed the title from Finisher: batch handle perfcounter && only send signal when waiter existed. to common/Finisher: batch handle perfcounter && only send signal when waiter existed. May 1, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented May 1, 2017

rebase please?

@majianpeng

This comment has been minimized.

Member

majianpeng commented May 3, 2017

update

}
ldout(cct, 10) << "finisher_thread done with " << ls << dendl;
ls.clear();
if (logger) {
logger->dec(l_finisher_queue_len, count);
logger->tinc(l_finisher_complete_lat, ceph_clock_now() - start);

This comment has been minimized.

@liewegas

liewegas May 3, 2017

Member

This changes what complete_lat means.. it's now a single latency measurement for the whole batch, whereas before it was a latency measurement for each completion from teh start of the batch. Which doesn't really make any sense, so this is good!

@liewegas liewegas added the needs-qa label May 3, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented May 3, 2017

retest this please

majianpeng added some commits Apr 6, 2017

common/perf_counter: make tinc() handle batch-processing
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
common/Finisher: batch handle perfcounter.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
common/Finisher: No waite_for_empty no signal.
Avoid every time to send a signal because wait_for_empty is rare event.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@liewegas liewegas merged commit 813df82 into ceph:master May 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment