New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: support optional argument for overriding default ctag excludes #14379

Merged
merged 1 commit into from Apr 8, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Apr 7, 2017

so instead of excluding all submodules, one can just exclude boost and
rocksdb using:

cmake -DCTAG_EXCLUDES="boost;rocksdb" ..

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested review from dmick and cbodley Apr 7, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 7, 2017

the followon of #14334

cmake: support optional argument for overriding default ctag excludes
so instead of excluding all submodules, one can just exclude boost and
rocksdb using:

  cmake -DCTAG_EXCLUDES="boost;rocksdb" ..

Signed-off-by: Kefu Chai <kchai@redhat.com>
@dmick

This comment has been minimized.

Member

dmick commented Apr 7, 2017

Have you tested that the default run creates tag files are the same before and after? If so, I'm happy

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 8, 2017

ps shows

/bin/sh -c cd /var/ceph/ceph/src && /usr/bin/ctags -R --c++-kinds=+p --fields=+iaS --extra=+q "--exclude=*.js" --exclude=civetweb --exclude=erasure-code/jerasure/jerasure --exclude=erasure-code/jerasure/gf-complete --exclude=rocksdb --exclude=googletest --exclude=spdk --exclude=xxHash --exclude=isa-l --exclude=lua --exclude=Beast --exclude=boost --exclude=dpdk --exclude=zstd

and

$ ls -lh ../src/tags
-rw-r--r-- 1 kefu kefu 32M Apr  8 11:35 ../src/tags

also tested using vim.

@tchaikov tchaikov merged commit 3f4c4bf into ceph:master Apr 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-cmake-ctags branch Apr 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment