Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
osd: Cleanup-Updated OSDMap.cc with C++11 style range-for loops #14381
i am trying to enumerate all "elem" your change, but maybe you can identify the rest of them without my help?
elem is good for a name of variable in books for data structure or algorithm libraries, but not for a variable with some tangible meaning.
I was coincidentally starting the same cleanup in OSDMap.cc so that I could switch the OSDMap types to live in a new 'osdmap' mempool, which requires changing all of these loops to either use auto for the iterator or the simplified loop syntax. So in this case let's move forward, but in general check first about cleanups like this since it does obscure the history and also makes backporting more difficult. Thanks!