New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: segment fault when shard id out of range #14389

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
5 participants
@mingshuaiwang

mingshuaiwang commented Apr 7, 2017

Signed-off-by: mingshuaiwang 736808191@qq.com

@tchaikov tchaikov changed the title from fix: segment fault when shard id out of range to rgw: segment fault when shard id out of range Apr 7, 2017

@mingshuaiwang

This comment has been minimized.

mingshuaiwang commented Apr 20, 2017

hi @yehudasa, can you help to review this pr?

@yehudasa

This comment has been minimized.

Member

yehudasa commented Apr 20, 2017

@mingshuaiwang looks ok. Can you open a ceph tracker issue for this problem and reference it using Fixes: in the commit message? Thanks

@mingshuaiwang

This comment has been minimized.

mingshuaiwang commented Apr 21, 2017

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Apr 26, 2017

@mingshuaiwang I think so; you should amend the commit message to add:

"Fixes: http://tracker.ceph.com/issues/19732"

@@ -1730,6 +1730,8 @@ int RGWDataChangesLog::list_entries(int shard, const real_time& start_time, cons
const string& marker,
string *out_marker,
bool *truncated) {
if (shard > num_shards)
return -EINVAL;

This comment has been minimized.

@cbodley

cbodley Apr 26, 2017

Contributor

if (shard >= num_shards)

This comment has been minimized.

@cbodley

cbodley May 17, 2017

Contributor

ping @mingshuaiwang, can you fix this check please?

This comment has been minimized.

@mingshuaiwang

mingshuaiwang May 19, 2017

@cbodley sorry, my bad, fixed~

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Apr 26, 2017

@cbodley thinks this may be reproducible by an ordinary S3 user, which...

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 26, 2017

@cbodley thinks this may be reproducible by an ordinary S3 user, which...

the user would need the datalog read cap to hit this

@mingshuaiwang

This comment has been minimized.

mingshuaiwang commented Apr 27, 2017

hi, @mattbenjamin I have changed the commit message

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Apr 27, 2017

@cbodley cool

@mattbenjamin

@mingshuaiwang the "Fixes:" statement should be in the body of the commit message, not the header line; can you do that?

@mingshuaiwang

This comment has been minimized.

mingshuaiwang commented Apr 28, 2017

@mattbenjamin Got it, thank you~

redickwang
rgw: segment fault when shard id out of range
Fixes: http://tracker.ceph.com/issues/19732

Signed-off-by: redickwang <redickwang@tencent.com>
@cbodley

This comment has been minimized.

@cbodley cbodley merged commit 2dc5859 into ceph:master May 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment