New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PG: only correct filestore collection bits on load #14397

Merged
merged 1 commit into from Apr 9, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Apr 7, 2017

PG::update_store_with_options() is called on load and when the pool
properties change, but if we only need to fix bits right at load time.
More importantly, but doing a second check on pool change, we may race
with a previously queued collection create that is not yet readable via
filestore, try to (synchronously) set the property again, and deadlock.

Fixes: http://tracker.ceph.com/issues/19541
Signed-off-by: Sage Weil sage@redhat.com

osd/PG: only correct filestore collection bits on load
PG::update_store_with_options() is called on load *and* when the pool
properties change, but if we only need to fix bits right at load time.
More importantly, but doing a second check on pool change, we may race
with a previously queued collection create that is not yet readable via
filestore, try to (synchronously) set the property again, and deadlock.

Fixes: http://tracker.ceph.com/issues/19541
Signed-off-by: Sage Weil <sage@redhat.com>

@tchaikov tchaikov self-requested a review Apr 7, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 7, 2017

retest this please

@liewegas

This comment has been minimized.

@tchaikov tchaikov merged commit 654faee into ceph:master Apr 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 9, 2017

some "make check" failures can be cured by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment