New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: emit cluster log messages on MDS health changes #14398

Merged
merged 2 commits into from Apr 14, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Contributor

jcsp commented Apr 7, 2017

Previously, when we got a beacon that updated the health
metrics for an MDS, the user would just see mysterious-looking
cluster log messages indicating a rising fsmap epoch number.

It would be good to do this for health messages in general at
some point, but for now just do it for the MDS ones.

Fixes: http://tracker.ceph.com/issues/19551
Signed-off-by: John Spray john.spray@redhat.com

@batrick

batrick approved these changes Apr 7, 2017

@batrick

This comment has been minimized.

Member

batrick commented Apr 7, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 10, 2017

Seen "successful failures" in test run, lines like cluster [ERR] MDS health message (mds.0): Metadata damage detected" in cluster log will need log whitelisting.

John Spray
mon: emit cluster log messages on MDS health changes
Previously, when we got a beacon that updated the health
metrics for an MDS, the user would just see mysterious-looking
cluster log messages indicating a rising fsmap epoch number.

It would be good to do this for health messages in general at
some point, but for now just do it for the MDS ones.

Fixes: http://tracker.ceph.com/issues/19551
Signed-off-by: John Spray <john.spray@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 13, 2017

Updated with log whitelists after wading through the failures

John Spray
qa: add log whitelists for MDS health messages
Now that we send these to the cluster log, we must
whitelist them in the tests that exercise those
unhealthy states.

Fixes: http://tracker.ceph.com/issues/19551
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp merged commit 517dbfd into ceph:master Apr 14, 2017

0 of 3 checks passed

Signed-off-by checking if commits are signed
Details
Unmodifed Submodules checking if PR has modified submodules
Details
default Build triggered. sha1 is merged.
Details

@jcsp jcsp deleted the jcsp:wip-19551 branch Apr 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment