Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon,mgr: move reweight-by-* to mgr #14404

Merged
merged 9 commits into from Apr 13, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

tchaikov commented Apr 8, 2017

No description provided.

@tchaikov tchaikov added mgr mon labels Apr 8, 2017

@tchaikov tchaikov requested a review from liewegas Apr 8, 2017

reply->set_tid(m->get_tid());
reply->set_data(odata);
con->send_message(reply);
bool DaemonServer::_reply(MCommand* m,

This comment has been minimized.

Copy link
@tchaikov

tchaikov Apr 8, 2017

Author Contributor

will remove the always-return true logic in another PR.

@tchaikov tchaikov force-pushed the tchaikov:wip-another-mgr-command branch 10 times, most recently from 48fee37 to a4fdb77 Apr 8, 2017

tchaikov added some commits Apr 8, 2017

mon/OSDMonitor: extract reweight_by_utilization into PGMap
Signed-off-by: Kefu Chai <kchai@redhat.com>
mon/OSDMonitor: add "osd reweightn" command
the "weights" parameter is an escaped serialized json dict, where double
quote is replaced with single quote.

Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/DaemonServer: extract reply out of handle_command()
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/DaemonServer: move reweight-by-* to mgr
Signed-off-by: Kefu Chai <kchai@redhat.com>
mon/MonCap: chmod mgr+w osd
so mgr is able to update osdmap with 'osd reweightn'

Signed-off-by: Kefu Chai <kchai@redhat.com>
osdc/Objecter: remove duplicated with_osdmap() template function
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/DaemonServer: always template the return value
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr,mon,osdc: more constness
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-another-mgr-command branch from a4fdb77 to 6646b35 Apr 10, 2017

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Apr 12, 2017

Error EDOM: Refusing to reweight: we only have 27 PGs across 3 osds!

/a/sage-2017-04-11_21:07:54-rados-wip-sage-testing---basic-smithi/1013639

@tchaikov tchaikov self-assigned this Apr 12, 2017

@tchaikov tchaikov changed the title mon,mgr: move reweight-by-* to mgr [DNM] mon,mgr: move reweight-by-* to mgr Apr 12, 2017

@tchaikov tchaikov removed the needs-qa label Apr 12, 2017

qa/suites: add mon-reweight-min-pgs-per-osd = 4
so we can run reweight commands in a small cluster with 3 OSD and 27
PGs.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov changed the title [DNM] mon,mgr: move reweight-by-* to mgr mon,mgr: move reweight-by-* to mgr Apr 13, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Apr 13, 2017

tested at http://pulpito.ceph.com/kchai-2017-04-13_05:10:51-rados-wip-sage-testing---basic-smithi/ using

teuthology-suite --ceph wip-sage-testing --filter="rados/singleton/{all/cephtool.yaml msgr-failures/many.yaml msgr/async.yaml objectstore/bluestore.yaml rados.yaml}" --suite rados --machine-type=smithi --sha1 7842e92aa155ddd1c61e049740a9ba13d2228803  --ceph-repo https://github.com/ceph/ceph-ci.git --suite-repo https://github.com/tchaikov/ceph.git --suite-branch wip-another-mgr-command

in which, 7842e92aa155ddd1c61e049740a9ba13d2228803 is the one tested by http://pulpito.ceph.com/sage-2017-04-11_21:07:54-rados-wip-sage-testing---basic-smithi/1013639/, which failed without ef7583d

@tchaikov tchaikov merged commit 9acd868 into ceph:master Apr 13, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-another-mgr-command branch Apr 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.