New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdma: msg/async/rdma: RDMA-CM, Pass specific ConnMgr info in constructor #14409

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
@Adirl

Adirl commented Apr 9, 2017

Pass specific information for RDMAConnTCP (and later for RDMAConnCM) in
the constructor.
This makes set_accept_fd() redundant.

Signed-off-by: Amir Vadai amir@vadai.me

msg/async/rdma: Pass specific ConnMgr info in constructor
Pass specific information for RDMAConnTCP (and later for RDMAConnCM) in
the constructor.
This makes set_accept_fd() redundant.

Issue: 995322
Change-Id: I10b4a626f180858465a378e886a238fe187180d5
Signed-off-by: Amir Vadai <amir@vadai.me>
@Adirl

This comment has been minimized.

Adirl commented Apr 9, 2017

@yuyuyu101
more changes for RDMA-CM
Please take a look

thanks

@Adirl Adirl changed the title from msg/async/rdma: Pass specific ConnMgr info in constructor to msg/async/rdma: RDMA-CM, Pass specific ConnMgr info in constructor Apr 9, 2017

@@ -99,7 +98,7 @@ class RDMAConnectedSocketImpl : public ConnectedSocketImpl {
uint32_t remote_qpn = 0;
RDMAConnectedSocketImpl(CephContext *cct, Infiniband* ib, RDMADispatcher* s,
RDMAWorker *w);
RDMAWorker *w, void *info = nullptr);

This comment has been minimized.

@yuyuyu101

yuyuyu101 Apr 9, 2017

Member

I think it should not assign to a nullptr default

@@ -71,6 +72,16 @@ RDMAConnTCP::RDMAConnTCP(CephContext *cct, RDMAConnectedSocketImpl *sock,
my_msg.peer_qpn = 0;
my_msg.gid = ibdev->get_gid(ibport);
socket->register_qp(qp);
if (_info) {

This comment has been minimized.

@yuyuyu101

yuyuyu101 Apr 9, 2017

Member

assert(_info)

This comment has been minimized.

@amirv

amirv Apr 9, 2017

Contributor

_info exists only for server sockets.
asking if (_info), is actually asking if is_server....

@Adirl

This comment has been minimized.

Adirl commented Apr 9, 2017

@yuyuyu101 yuyuyu101 merged commit 1a9ab80 into ceph:master Apr 11, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@theanalyst theanalyst changed the title from msg/async/rdma: RDMA-CM, Pass specific ConnMgr info in constructor to rdma: msg/async/rdma: RDMA-CM, Pass specific ConnMgr info in constructor Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment