New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Thrasher: handle "OSD has the store locked" gracefully #14415

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Apr 9, 2017

On slower machines (VPS, OVH) it takes time for the OSD to go down.

Fixes: http://tracker.ceph.com/issues/19556
Signed-off-by: Nathan Cutler ncutler@suse.com

@dzafman

I'm a Python novice so it looks ok at face value.

stdout=StringIO(), stderr=StringIO())
if proc.exitstatus == 0:
break
if proc.exitstatus == 1 and stderr == "OSD has the store locked":

This comment has been minimized.

@tchaikov

tchaikov Apr 11, 2017

Contributor

s/stderr/proc.stderr/ ?

break
if proc.exitstatus == 1 and stderr == "OSD has the store locked":
continue
if proc.exitstatus:

This comment has been minimized.

@tchaikov

tchaikov Apr 11, 2017

Contributor

nit, proc.exitstatus is always True in this branch.

tests: Thrasher: handle "OSD has the store locked" gracefully
On slower machines (VPS, OVH) it takes time for the OSD to go down.

Fixes: http://tracker.ceph.com/issues/19556
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Apr 11, 2017

@tchaikov Thanks! Please have another look. . .

@tchaikov tchaikov added the needs-qa label Apr 11, 2017

@tchaikov tchaikov self-assigned this Apr 12, 2017

@tchaikov tchaikov merged commit 1b54b5f into ceph:master Apr 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@smithfarm smithfarm deleted the smithfarm:wip-19556 branch Apr 18, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Apr 18, 2017

@tchaikov Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment