New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/MonClient: make get_mon_log_message() atomic #14422

Merged
merged 1 commit into from Apr 12, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Apr 10, 2017

  • LogClient: move reset_session() into get_mon_log_message() and add a
    "flush" param to the latter. so it can get_mon_log_message()
    atomically. otherwise another call changing the log queue could sneak
    in between reset_session() and get_mon_log_message().
  • MonClient: add a "flush" param to do_send() so we can reset the
    LogClient session once we are connected to a monitor.

Fixes: http://tracker.ceph.com/issues/19427
Signed-off-by: Kefu Chai kchai@redhat.com

mon/MonClient: make get_mon_log_message() atomic
* LogClient: move reset_session() into get_mon_log_message() and add a
  "flush" param to the latter. so it can get_mon_log_message()
  atomically. otherwise another call changing the log queue could sneak
  in between reset_session() and get_mon_log_message().
* MonClient: add a "flush" param to do_send() so we can reset the
  LogClient session once we are connected to a monitor.

Fixes: http://tracker.ceph.com/issues/19427
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from liewegas and jdurgin Apr 10, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 10, 2017

retest this please (jenkins agent issue)

@liewegas

yes!

@liewegas liewegas merged commit 0487226 into ceph:master Apr 12, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@tchaikov tchaikov deleted the tchaikov:wip-19427 branch Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment