New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/MgrClient: fix reconnect event leak #14431

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
5 participants
@liewegas
Member

liewegas commented Apr 10, 2017

@liewegas liewegas requested a review from tchaikov Apr 10, 2017

@@ -49,6 +49,11 @@ void MgrClient::shutdown()
{
Mutex::Locker l(lock);
if (connect_retry_callback) {

This comment has been minimized.

@tchaikov

tchaikov Apr 11, 2017

Contributor

how about report_callback?

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 11, 2017

oh cool, i just saw this leak in the rgw suite. i opened http://tracker.ceph.com/issues/19580 for it

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 11, 2017

@tchaikov added report_callback cleanup
@cbodley added link to ticket in commit

@@ -49,6 +49,15 @@ void MgrClient::shutdown()
{
Mutex::Locker l(lock);
if (connect_retry_callback) {
timer.cancel_cevent(connect_retry_callback);

This comment has been minimized.

@jcsp

jcsp Apr 15, 2017

Contributor

s/cancel_cevent/cancel_event/

mgr/MgrClient: fix reconnect event leak
Signed-off-by: Sage Weil <sage@redhat.com>

@yuriw yuriw merged commit 82c0ea7 into ceph:master Apr 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment