New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: make bluestore_max_blob_size parameter hdd/ssd case dependant #14434

Merged
merged 5 commits into from Apr 20, 2017

Conversation

Projects
None yet
3 participants
@ifed01
Contributor

ifed01 commented Apr 10, 2017

Additionally some cleanup around dynamically loadable bluestore params.

Signed-off-by: Igor Fedotov ifedotov@mirantis.com

@liewegas liewegas added the bluestore label Apr 10, 2017

@markhpc markhpc added the performance label Apr 12, 2017

@liewegas liewegas self-requested a review Apr 12, 2017

@liewegas

aside from the set_compression call site i think this looks fine (including the atomics).

comp_min_blob_size = cct->_conf->bluestore_compression_max_blob_size;
} else {
assert(bdev);
if (bdev->is_rotational()) {

This comment has been minimized.

@liewegas

liewegas Apr 14, 2017

Member

need to update the caller in handle_conf_chagne with if (bdev) guard, and then call this again after bdev is initialized in mkfs() and _open_super_meta() (match _set_alloc_sizes() callers)

@liewegas

liewegas Apr 14, 2017

Member

need to update the caller in handle_conf_chagne with if (bdev) guard, and then call this again after bdev is initialized in mkfs() and _open_super_meta() (match _set_alloc_sizes() callers)

This comment has been minimized.

@ifed01

ifed01 Apr 17, 2017

Contributor

Fixed all but set_compression() call from mkfs, it seems unnecessary...

@ifed01

ifed01 Apr 17, 2017

Contributor

Fixed all but set_compression() call from mkfs, it seems unnecessary...

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Apr 14, 2017

Member

rebase please

Member

liewegas commented Apr 14, 2017

rebase please

Igor Fedotov added some commits Apr 10, 2017

Igor Fedotov
os/bluestore: respect hdd/ssd case for compression min/max blob size …
…paramteters

Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Igor Fedotov
os/bluestore: make bluestore_max_blob_size parameter hdd/ssd dependant.
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Igor Fedotov
os/bluestore: make dynamically loadable config parameters atomic
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Igor Fedotov
os/bluestore: load dynamic params from a single place
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>

 Please enter the commit message for your changes. Lines starting
Igor Fedotov
test/store_test: fix test cases broken by blob reuse as they depend o…
…n applied min_alloc_size.

Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>

@liewegas liewegas merged commit adada74 into ceph:master Apr 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ifed01 ifed01 deleted the ifed01:wip-bluestore-params branch May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment