New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: build-doc/serve-doc fixes #14438

Merged
merged 2 commits into from Apr 11, 2017

Conversation

Projects
None yet
2 participants
@theanalyst
Member

theanalyst commented Apr 10, 2017

virtualenv we create for docs would default to system default python which might be python3 in many OSes, this would fail eventually as we use the sphinx-ditaa module which errors out in py3. Also added a small print statement on the port we're serving in serve-doc

theanalyst added some commits Apr 10, 2017

script: build-doc use python2 only for virtualenv
This is because the sphinx-ditaa package and ceph's rbd/rgw/rados pybind
require python2

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
script: serve-doc print the port we're serving
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

@theanalyst theanalyst requested review from tchaikov and Apr 10, 2017

@theanalyst

This comment has been minimized.

Member

theanalyst commented Apr 10, 2017

@tchaikov not sure if pybind for rados/rbd/rgw support py3 yet, if yes, then probably in future, we could fix the https://github.com/ceph/sphinx-ditaa to support py3

@ghost

ghost approved these changes Apr 10, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 11, 2017

@theanalyst our pybinds do support py3. i am looking at sphinx-ditaa, maybe we can note this down in our tracker.

@tchaikov tchaikov merged commit 5a00a45 into ceph:master Apr 11, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@theanalyst

This comment has been minimized.

Member

theanalyst commented Apr 11, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 11, 2017

@theanalyst thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment