Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
os/bluestore/NVMEDevice: fix the compilation issue for collect_metadata #14455
Speaking of which, I think @ifed01 was having some trouble getting SPDK to compile the other day. Since DPDK and SPDK are now both submodules, perhaps we can enable the build by default? (We can always disable it in the package builds if we don't want to ship it.)
In current code, we could find spdk is controlled by a macro "HAVE_SPDK":
And HAVE_SPDK will be defined only when "WITH_SPDK" is on when run cmake.
In my opinion, we could set "WITH_SPDK" to on as default(maybe off when ship), and add an new option in config_opt.h(maybe osd_device_type?), when set "userspace", NVMEDevice(spdk) will be used, otherwise, "kernel", KernelDevice will be used.
@yuyuyu101, do you agree?