New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: bucket stats display bucket index type #14466

Merged
merged 1 commit into from Apr 17, 2017

Conversation

Projects
None yet
3 participants
@fangyuxiangGL
Contributor

fangyuxiangGL commented Apr 12, 2017

Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com

@fangyuxiangGL

This comment has been minimized.

Contributor

fangyuxiangGL commented Apr 12, 2017

@Liuchang0812 @cbodley

hi, optimize the codes as your suggestion, but i made something wrong that I deleted previous branch.

could you review again for me? thx

break;
}
default:
break;

This comment has been minimized.

@Liuchang0812

Liuchang0812 Apr 12, 2017

Contributor

how about str = "Unknown"?

This comment has been minimized.

@fangyuxiangGL

fangyuxiangGL Apr 12, 2017

Contributor

ok. 👍

@Liuchang0812

LGTM

@fangyuxiangGL

This comment has been minimized.

Contributor

fangyuxiangGL commented Apr 12, 2017

retest this please

return out << str;
}

This comment has been minimized.

@cbodley

cbodley Apr 12, 2017

Contributor

can you try to shorten this function a bit? the temporary string str shouldn't be necessary. something like:

inline std::ostream& operator<<(std::ostream& out, RGWBucketIndexType index_type)
{
  switch (index_type) {
  case RGWBIType_Normal:
    return out << "Normal";
  case RGWBIType_Indexless:
    return out << "Indexless";
  default:
    return out << "Unknown";
  }
}

This comment has been minimized.

@fangyuxiangGL

fangyuxiangGL Apr 13, 2017

Contributor

ok~ done ..

@cbodley cbodley self-assigned this Apr 12, 2017

@cbodley cbodley added the rgw label Apr 12, 2017

rgw: bucket stats display bucket index type
Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com

@cbodley cbodley merged commit 7e19db2 into ceph:master Apr 17, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@fangyuxiangGL fangyuxiangGL deleted the fangyuxiangGL:bi branch Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment