New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give requested scrub work a higher priority #14488

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@dzafman
Member

dzafman commented Apr 12, 2017

Once started we now queue scrub work at higher priority than
scheduled scrubs.

Fixes: http://tracker.ceph.com/issues/15789

Signed-off-by: David Zafman dzafman@redhat.com

@@ -942,6 +942,9 @@ OPTION(osd_snap_trim_cost, OPT_U32, 1<<20) // set default cost equal to 1MB io
OPTION(osd_scrub_priority, OPT_U32, 5)
// set default cost equal to 50MB io
OPTION(osd_scrub_cost, OPT_U32, 50<<20)
// set requested scrub priority higher than scrub priority to make the
// requested scrubs jump the queue of scheduled scrubs
OPTION(osd_requested_scrub_priority, OPT_U32, 120)

This comment has been minimized.

@dzafman

dzafman Apr 13, 2017

Member

I noticed some PGQueueable message handling items are queued at 127, so I chose a high value less than that.

@dzafman dzafman removed the needs-test label Apr 17, 2017

@dzafman

This comment has been minimized.

Member

dzafman commented Apr 17, 2017

@dzafman dzafman requested a review from jdurgin Apr 17, 2017

@dzafman dzafman changed the title from scrub: make requested scrubs jump the queue to Give requested scrub work a higher priority Apr 17, 2017

osd: Give requested scrub work a higher priority
Once started we now queue scrub work at higher priority than
scheduled scrubs.

Fixes: http://tracker.ceph.com/issues/15789

Signed-off-by: David Zafman <dzafman@redhat.com>

@dzafman dzafman merged commit 964ee3a into ceph:master Apr 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dzafman dzafman deleted the dzafman:wip-15789 branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment