New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: add mon_debug_no_require_luminous #14490

Merged
merged 10 commits into from Apr 15, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Apr 12, 2017

This allows us to create new clusters without the luminous osdmap flag,
improving test coverage of the cluster when operating in the not-quite-
yet-upgraded state in compatibility mode (albeit without any actual kraken
or jewel osds in the mix).

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 12, 2017

Pulled these patches out of wip-snapset so we can test them against master (and merge them) first, without worrying about all the changes in wip-snapset. Also need this for wip-past-intervals.

@liewegas liewegas self-assigned this Apr 12, 2017

mon/OSDMonitor: add mon_debug_no_require_luminous
Add debug option not to set the require_luminous osdmap flag on mkfs, for
debugging purposes.

Signed-off-by: Sage Weil <sage@redhat.com>

@tchaikov tchaikov self-requested a review Apr 13, 2017

liewegas added some commits Apr 10, 2017

mon/OSDMonitor: ignore health checks about require_luminous if debug …
…flag is set

This makes it tedious for teuthology health checks to proceed when we
deliberately run luminous osds without this flag.

Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: fix initial map when require_luminous_osds not set on…
… mkfs

If we don't set the luminous flag, we should not set the new luninous
fields or else we'll get a crc mismatch.  (Funnily that happens in the
epoch where the flag is eventually set and the encoded map finally includes
the field we have set in memory.)

Signed-off-by: Sage Weil <sage@redhat.com>
qa/suites/rados: require_luminous_osds at end of run, then scrub
Signed-off-by: Sage Weil <sage@redhat.com>
qa/tasks/exec_on_cleanup.py: add
Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: fix creating pg trimming during upgrade
The creating pgs are in the PGMap with the CREATING
state bit set.

Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: slightly better debug output
Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: require_luminous_osds for pg-remap[-items]
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Apr 14, 2017

@tchaikov can you look at 7959760?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented on src/mon/OSDMonitor.cc in 7959760 Apr 14, 2017

ahh, thanks for fixing this!

@tchaikov tchaikov added the bug fix label Apr 14, 2017

liewegas added some commits Apr 14, 2017

qa/suites/rados: expand other collections with no-require-luminous
Signed-off-by: Sage Weil <sage@redhat.com>
qa/suites/rados/thrash: do not thrash cluster full without luminous flag
The interface changes with the luminous flag; this will fail.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit d82ac99 into ceph:master Apr 15, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@liewegas liewegas deleted the liewegas:wip-no-luminous branch Apr 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment