New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: two minor fixes #14494

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
@drunkard
Contributor

drunkard commented Apr 13, 2017

  • doc: indent style fixes
  • doc: referred content should be ruleset ID
doc: indent style fixes
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
@@ -188,7 +188,7 @@ consider removing them when you no longer need your pool::
ceph osd pool get {pool-name} crush_ruleset
If the ruleset was "123", for example, you can check the other pools like so::
If the ruleset ID was "123", for example, you can check the other pools like so::

This comment has been minimized.

@tchaikov

tchaikov Apr 13, 2017

Contributor

i think we are trying to use "ruleset" to note the "id", do you find somewhere else we are using "ruleset id" in the doc, and it's causing the confusion?

This comment has been minimized.

@drunkard

drunkard Apr 13, 2017

Contributor

Only exists in release-notes, but it confused me in my first reading, shouldn't we make it more clear?

This comment has been minimized.

@drunkard

drunkard Apr 13, 2017

Contributor

Actually, we don't have enough documents on "ceph osd crush rule ..." operating topic, these commands take ruleset name as argument, so I think it's necessary to distinguish "name" and "id".

This comment has been minimized.

@tchaikov

tchaikov Apr 18, 2017

Contributor

i think we are using "rulename" to reference the name of ruleset, and use "ruleset" to reference the id of it. see http://docs.ceph.com/docs/master/rados/operations/pools/#set-pool-values and http://docs.ceph.com/docs/master/rados/operations/crush-map/#crush-map-rules. if you happen to find ruleset id anywhere else in the doc, could you point me to it? thanks.

This comment has been minimized.

@drunkard

drunkard Apr 24, 2017

Contributor

Got it, only found in release-notes by now, get those using: grep -Ri 'ruleset id' doc/

@liewegas liewegas merged commit 1919297 into ceph:master Apr 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment