New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: pg-remap -> pg-upmap #14556

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Apr 14, 2017

'remap' is to non-specific a name. In particular, it
sounds like it is related to the 'remapped' PG state
but in reality it is not related.

'upmap' or 'pg-upmap' is more specific: it maps a pgid
to the 'up' set value (or item)

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested review from branch-predictor and dzafman and removed request for branch-predictor Apr 14, 2017

@dzafman

dzafman requested changes Apr 18, 2017 edited

I did a git grep in your branch and saw this:

$ git grep pg.remap
src/mon/OSDMonitor.cc: ss << "you must enable 'mon osd allow pg remap = true' on the mons before you can adjust pg_upmap. note that pre-luminous clients will no longer be able to communicate with the cluster.";
src/mon/OSDMonitor.cc: ss << "you must enable 'mon osd allow pg remap = true' on the mons before you can adjust pg_upmap. note that pre-luminous clients will no longer be able to communicate with the cluster.";
src/mon/OSDMonitor.cc: ss << "you must enable 'mon osd allow pg remap = true' on the mons before you can adjust pg_upmap. note that pre-luminous clients will no longer be able to communicate with the cluster.";
src/mon/OSDMonitor.cc: ss << "you must enable 'mon osd allow pg remap = true' on the mons before you can adjust pg_upmap. note that pre-luminous clients will no longer be able to communicate with the cluster.";
src/vstart.sh: mon osd allow pg remap = true

osd: pg-remap -> pg-upmap
'remap' is to non-specific a name.  In particular, it
sounds like it is related to the 'remapped' PG state
but in reality it is not related.

'upmap' or 'pg-upmap' is more specific: it maps a pgid
to the 'up' set value (or item)

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Apr 18, 2017

@liewegas liewegas merged commit ee1bb01 into ceph:master Apr 19, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@liewegas liewegas deleted the liewegas:wip-pgupmap branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment