New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/init-ceph.in: allow one((re)?start|stop) as commands #14560

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
4 participants
@wjwithagen
Contributor

wjwithagen commented Apr 14, 2017

  • On FreeBSD these are the service command to start a service
    even if the service is not activated in /etc/rc.conf
    Which will allow ceph-disk and ceph-deploy to start even without
    setting /etc/rc.conf

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@@ -1,4 +1,4 @@
#!/bin/sh

This comment has been minimized.

@joscollin

joscollin Apr 16, 2017

Member

I understand that your intention is to modify the script for both Linux and FreeBSD. If so why removing this line ?

This comment has been minimized.

@wjwithagen

wjwithagen Apr 16, 2017

Contributor

@joscollin
'mmmm, I guess something went wrong with the PR submit
Will check, thanx.

@@ -513,6 +514,11 @@ for name in $what; do
$0 $options start $name
;;
onerestart)

This comment has been minimized.

@tchaikov

tchaikov Apr 18, 2017

Contributor

if onerestart is equivalent to restart, why not just put

restart|onerestart)
   ...

?

src/init-ceph.in: allow one((re)?start|stop) as commands
 - One FreeBSD these are the service command to start a service
   even if the service is not activated in /etc/rc.conf
   Which will allow ceph-disk and ceph-deploy to start even without
   setting /etc/rc.conf

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Apr 22, 2017

@tchaikov @joscollin
Gent's looks like I addressed you reviews, and it tests oke.
Perhaps run it thru QA although I understand from Sage that this is not really used much any longer

@joscollin

This comment has been minimized.

Member

joscollin commented Apr 22, 2017

@wjwithagen The changes looks good to me. Kefu will take it forward, as I have lesser permissions.

@liewegas liewegas merged commit cff7f93 into ceph:master Apr 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment