New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Tidy up fs/ suite #14575

Merged
merged 8 commits into from Apr 24, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Apr 15, 2017

I noticed that we had picked up btrfs again, and now seems like a good time to sort out the horribly misnamed 'recovery' subsuite too.

This is based on #14018 because it had some test changes in before.

@jcsp jcsp added cephfs tests labels Apr 15, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 15, 2017

retest this please

@jcsp jcsp changed the title from [DNM] Tidy up fs/ suite to qa: Tidy up fs/ suite Apr 15, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Apr 15, 2017

Once this is reviewed it can either merge after #14018 or have those first four commits dropped.

@jcsp jcsp requested a review from batrick Apr 15, 2017

@ukernel

This comment has been minimized.

Member

ukernel commented Apr 24, 2017

LGTM

jcsp added some commits Apr 15, 2017

qa: don't permute object store for functional tests
These are unit tests for specific CephFS functionality,
it is gratuitous to repeat them with different underlying
RADOS object stores.

We retain coverage of XFS vs. bluestore in the workload tests.

Signed-off-by: John Spray <john.spray@redhat.com>
qa/suites/fs: put simple functional tests together
Most of what's in basic/ is "workload" type testing
(i.e. a simple cluster cluster configuration and then
running a script inside the client), which gets
permuted in various ways.  Move the simpler
functional tests out with the others like themselves.

Signed-off-by: John Spray <john.spray@redhat.com>
qa/suites/fs: more meaningful names for sub suites
The "recovery" sub suite was originally tests for
client/mds recovery in certain failure cases, it has
since grown to include lots of unit testing of
various features using CephFSTestCase.

The "basic" suite is now specifically just running workloads
now that I've moved out the smaller functional tests.

Signed-off-by: John Spray <john.spray@redhat.com>
qa: remove unused fs/ dir
The objectstore/ dir is now selecting the backing fs.

Signed-off-by: John Spray <john.spray@redhat.com>
qa/suites: don't use btrfs for cephfs testing
This change happened a while back, but it got rolled back
when the generic objectstore/ dir had its filestore
entry split out into xfs and btrfs in 208675a.

Signed-off-by: John Spray <john.spray@redhat.com>
qa/tasks/cephfs: clean up mount point setup
Previously were sometimes trying to maintain a mounted
client across a filesystem destroy/create.

Signed-off-by: John Spray <john.spray@redhat.com>
qa: switch off btrfs for multimds and kcephfs
Signed-off-by: John Spray <john.spray@redhat.com>
qa: update links for modified fs subsuite names
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp merged commit 6fad8cc into ceph:master Apr 24, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@jcsp jcsp deleted the jcsp:wip-cephfs-suites branch Apr 24, 2017

@yehudasa

This comment has been minimized.

Member

yehudasa commented Apr 24, 2017

@jcsp this broke a few suites: rgw, rbd, krbd, hadoop. All of the above have symbolic link pointing at fs/xfs.yaml.

@yehudasa

This comment has been minimized.

Member

yehudasa commented Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment