New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluestore/NVMEDEVICE: update SPDK to version 17.03 #14585

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
2 participants
@optimistyzy
Contributor

optimistyzy commented Apr 17, 2017

Do some minor changes:

1 Restrict the total DPDK memory used by an osd instance.
change the name from bluestore_spdk_socket_mem to
bluestore_spdk_mem.

2 use spdk_env_init instead of rte_eal_init. The reason is that
SPDK lib invokes rte_eal_init which reduces the initilization
paramter conversion and check, also spdk 17.03 invokes
spdk_vtophys_register_dpdk_mem() (which is an internal function)
in spdk_env_init, and this func must be called.

Signed-off-by: optimistyzy optimistyzy@gmail.com

@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy
Contributor

optimistyzy commented Apr 17, 2017

@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy

optimistyzy Apr 17, 2017

Contributor

retest this please

Contributor

optimistyzy commented Apr 17, 2017

retest this please

bluestore/NVMEDEVICE: update SPDK to version 17.03
Do some minor changes:

1 Restrict the total DPDK memory used by an osd instance.
change the name from bluestore_spdk_socket_mem to
bluestore_spdk_mem.

2 use spdk_env_init instead of rte_eal_init. The reason is that
SPDK lib invokes rte_eal_init which reduces the initilization
paramter conversion and check, also spdk 17.03 invokes
spdk_vtophys_register_dpdk_mem() (which is an internal function)
in spdk_env_init, and this func must be called.

Signed-off-by: optimistyzy <optimistyzy@gmail.com>
@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy

optimistyzy Apr 18, 2017

Contributor

@yuyuyu101 can this be merged? Also for we need to change the repo of spdk with the version, and I also submitted it, what the error reported by "Unmodifed Submodules — Approval needed: modified submodules found "

Contributor

optimistyzy commented Apr 18, 2017

@yuyuyu101 can this be merged? Also for we need to change the repo of spdk with the version, and I also submitted it, what the error reported by "Unmodifed Submodules — Approval needed: modified submodules found "

@yuyuyu101 yuyuyu101 merged commit 5737edf into ceph:master Apr 18, 2017

2 of 3 checks passed

Unmodifed Submodules Approval needed: modified submodules found
Details
Signed-off-by all commits in this PR are signed
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment