Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: refine fsync/close writeback error handling #14589

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Copy link
Contributor

jcsp commented Apr 17, 2017

Previously, errors stuck indelibly to the inode, which
meant that a close call would see an error even if the
user already dutifully fsync()'d and handled it.

We should emit each error only once per file handle.

Signed-off-by: John Spray john.spray@redhat.com

@jcsp jcsp requested a review from jtlayton Apr 17, 2017

@jtlayton
Copy link
Contributor

jtlayton left a comment

Looks good to me!

John Spray
client: refine fsync/close writeback error handling
Previously, errors stuck indelibly to the inode, which
meant that a close call would see an error even if the
user already dutifully fsync()'d and handled it.

We should emit each error only once per file handle.

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp force-pushed the jcsp:wip-19640 branch from 35efc70 to 1a69bec Apr 18, 2017

@jcsp jcsp merged commit d98e19f into ceph:master Apr 18, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@jcsp jcsp deleted the jcsp:wip-19640 branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.