New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/PGMonitor: clean up min/max span warning #14611

Merged
merged 1 commit into from Apr 24, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Apr 18, 2017

Clean up option naming.

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested a review from dzafman Apr 18, 2017

max_osd_perc_avail = perc_avail;
if (perc_avail < min_osd_perc_avail)
min_osd_perc_avail = perc_avail;
float usage = ((float)(p->second.kb - p->second.kb_avail)) /

This comment has been minimized.

@dzafman

dzafman Apr 18, 2017

Member

FYI: kb_used == kb - kb_avail, so it can be used here (see OSDService::update_osd_stat()).

@@ -99,3 +99,6 @@
* The RGW api for getting object torrent has changed its params from 'get_torrent'
to 'torrent' so that it can be compatible with Amazon S3. Now the request for
object torrent is like 'GET /ObjectName?torrent'.
* The mon_warn_osd_usage_percent option has been renamed

This comment has been minimized.

@dzafman

dzafman Apr 18, 2017

Member

The original change is so new I'm not sure it was in any releases to warrant a release note about the name of the option changing.

ss << "Difference in osd space utilization " << ((max_osd_perc_avail - min_osd_perc_avail) *100) << "% greater than " << (g_conf->mon_warn_osd_usage_percent * 100) << "%";
ss << "difference between min (" << min_osd_usage << ") and max ("
<< max_osd_usage << ") osd usage "
<< diff << " > " << g_conf->mon_warn_osd_usage_min_max_delta

This comment has been minimized.

@dzafman

dzafman Apr 18, 2017

Member

Why change to .## output instead of ##% when this is user visible health information? We might even want to use roundf() to limit the number of digits. For example, only showing to 1/10 of a percent:

roundf(diff * 1000) / 10 << "%"

mon/PGMonitor: clean up min/max span warning
Clean up option naming.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Apr 18, 2017

@dzafman

This comment has been minimized.

Member

dzafman commented Apr 21, 2017

retest this please

@dzafman

:+1

@liewegas liewegas added the needs-qa label Apr 24, 2017

@liewegas liewegas merged commit 8a3716a into ceph:master Apr 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-mon-warn-cleanup branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment