New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: Implement peering state timing #14627

Merged
merged 1 commit into from May 4, 2017

Conversation

Projects
None yet
3 participants
@badone
Contributor

badone commented Apr 19, 2017

Gather a history of peering states and time spent within them.

Signed-off-by: Brad Hubbard bhubbard@redhat.com

@badone

This comment has been minimized.

Contributor

badone commented Apr 20, 2017

Test this please

@badone

This comment has been minimized.

Contributor

badone commented Apr 21, 2017

Jenkins test this please

osd: Implement peering state timing
Gather a history of peering states and time spent within them.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone

This comment has been minimized.

Contributor

badone commented Apr 24, 2017

Jenkins test this please

@badone badone removed the needs-qa label Apr 24, 2017

@@ -271,6 +331,7 @@ PG::PG(OSDService *o, OSDMapRef curmap,
PG::~PG()
{
pgstate_history.set_pg_in_destructor();

This comment has been minimized.

@jdurgin

jdurgin Apr 27, 2017

Member

I think this destructor-related code could be avoided by declaring pgstate_history after recovery_state in PG.h, so that every NamedState instance is destroyed (and exit() is called) before the pgstate_history object is destroyed.

Moving the pgstate_history instance to PrimaryLogPG might be necessary to handle the snap_trimmer_machine declared there.

This comment has been minimized.

@badone

badone May 2, 2017

Contributor

After looking into this and discussions with Josh we decided that changing the destructor-related code is probably not worth the extra effort involved (it's tricky due to object lifetimes).

@badone badone added needs-qa and removed wip-badone-testing labels May 2, 2017

@jdurgin

jdurgin approved these changes May 2, 2017

@liewegas liewegas merged commit 7e79a4e into ceph:master May 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment