New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: pass -d0 to b2 if not CMAKE_VERBOSE_MAKEFILE #14651

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Apr 20, 2017

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the build/ops label Apr 20, 2017

@tchaikov tchaikov requested a review from mattbenjamin Apr 20, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 20, 2017

jenkins retest this please

cmake: pass -d0 to b2 if not CMAKE_VERBOSE_MAKEFILE
also do not hardwire the built components

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from cbodley Apr 20, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 20, 2017

so the ./b2 is less chatty when building/installing by default.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 20, 2017

looks okay to me - what controls this CMAKE_VERBOSE_MAKEFILE variable?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 20, 2017

@cbodley

cmake -DCMAKE_VERBOSE_MAKEFILE=ON

=)

and per https://cmake.org/cmake/help/v3.0/variable/CMAKE_VERBOSE_MAKEFILE.html, project() sets it to FALSE.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 24, 2017

@cbodley can i take your comment as a LGTM =)

@tchaikov tchaikov added the needs-qa label Apr 25, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 25, 2017

retest this please

@liewegas liewegas merged commit 7e2a286 into ceph:master Apr 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-silent-boost-build branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment