New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: remove "mds log" config option #14652

Merged
merged 1 commit into from Apr 24, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Contributor

jcsp commented Apr 20, 2017

This was occasionally useful for establishing a journal-less
performance baseline, but it has two big problems:

  • We don't test it, so it's probably broken a lot of the time
  • It sounds a lot to a naive user like an option for controlling
    logging.

IMO, anyone who wants this behaviour is in sufficiently advanced
territory that then can hack it in and recompile, we don't need
to leave dangerous things like this in our releases.

Fixes: http://tracker.ceph.com/issues/18816
Signed-off-by: John Spray john.spray@redhat.com

mds: remove "mds log" config option
This was occasionally useful for establishing a journal-less
performance baseline, but it has two big problems:
* We don't test it, so it's probably broken a lot of the time
* It sounds a lot to a naive user like an option for controlling
  logging.

IMO, anyone who wants this behaviour is in sufficiently advanced
territory that then can hack it in and recompile, we don't need
to leave dangerous things like this in our releases.

Fixes: http://tracker.ceph.com/issues/18816
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp added the cephfs label Apr 20, 2017

@jcsp jcsp requested a review from ukernel Apr 20, 2017

@jcsp jcsp merged commit c2fb170 into ceph:master Apr 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-18816 branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment