Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rbd, librbd: migrate atomic_t to std::atomic (rodan) #14656
the rgw bits look pretty good, i'll get this into a testing branch for the rgw suite
i was a bit confused by the commits called
@cbodley I am sorry for the inconsistency-- I had originally done this whole thing as a single giant change and then made some separate commits for things like the flags. Unfortunately, I didn't base my changes on master and things became a bit confused during all the rebasing and shuffling, partly because stuff stopped compiling and I finally wound up just changing my mind on doing that as a separate change since it was causing me to also get confused.
I agree that ultimately since I'm already in here fiddling with the types, it makes sense to just move stuff used as a Boolean flag to type atomic. In the "final" PR (gojira), I lost a commit and had to do a large change that does exactly that.
I'm hoping to avoid it, but if this stuff is altogether still too confusing I can try to rework the commits again. Another thought is that I could perhaps take that single commit out of this PR and make sure it's in "gojira".