New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: add support for delete marker expiration in s3 lifecycle. #14703

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
5 participants
@zhangsw
Contributor

zhangsw commented Apr 21, 2017

If bucket versioning is enabled, and delete marker is the only version of some object, this marker can be removed according to the lifecycle config.

Fixes: http://tracker.ceph.com/issues/19730

Signed-off-by: Zhang Shaowen zhangshaowen@cmss.chinamobile.com

@dang

dang approved these changes Apr 21, 2017

@yehudasa

This comment has been minimized.

Member

yehudasa commented Apr 27, 2017

@zhangsw can you add a test for it in s3-tests?

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented May 2, 2017

@yehudasa OK, I'll do it~

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented May 4, 2017

@yehudasa I've added the test case in ceph/s3-tests#158

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented May 9, 2017

@yehudasa ping..

@yehudasa

This comment has been minimized.

Member

yehudasa commented May 10, 2017

@zhangsw will try to follow up on this one this week

@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Jun 2, 2017

@yehudasa ping..

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 15, 2017

verified that new tests in ceph/s3-tests#158 pass when rgw lc debug interval = 10

@dang

This comment has been minimized.

Contributor

dang commented Jun 15, 2017

@oritwas I don't have permission to merge to this repository, otherwise I would have merged it long ago.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 15, 2017

jenkins test this please

1 similar comment
@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Jun 16, 2017

jenkins test this please

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 16, 2017

make check failures should be fixed with #15730, can you rebase please?

rgw: add support for delete marker expiration in s3 lifecycle.
Fixes: http://tracker.ceph.com/issues/19730

Signed-off-by: Zhang Shaowen <zhangshaowen@cmss.chinamobile.com>
@zhangsw

This comment has been minimized.

Contributor

zhangsw commented Jun 19, 2017

@cbodley I've rebased it.

@cbodley cbodley merged commit 4908814 into ceph:master Jun 20, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details

@zhangsw zhangsw deleted the zhangsw:feature-lifecycle-deletemarker branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment