New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg: Increase loglevels on some messages #14707

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
2 participants
@wjwithagen
Contributor

wjwithagen commented Apr 21, 2017

  • Logging with --debug-ms=20 swamps the logfile with messages that
    are mostly internal to the functioning of the messages queues.
    They tend to be very verbose info on what is going on, but not
    informative unless the internals are being debugged.

    So set the level for those messages > 20 to allow better filtering

@wjwithagen wjwithagen requested review from yuyuyu101 and tchaikov Apr 21, 2017

@@ -255,7 +255,7 @@ void EventCenter::delete_file_event(int fd, int mask)
return ;
}
EventCenter::FileEvent *event = _get_file_event(fd);
ldout(cct, 20) << __func__ << " delete event started fd=" << fd << " mask=" << mask
ldout(cct, 21) << __func__ << " delete event started fd=" << fd << " mask=" << mask

This comment has been minimized.

@yuyuyu101

yuyuyu101 Apr 21, 2017

Member

you can set to 30... 21 isn't a regular level.

@@ -140,7 +140,7 @@ void NetworkStack::start()
Worker* NetworkStack::get_worker()
{
ldout(cct, 10) << __func__ << dendl;
ldout(cct, 21) << __func__ << dendl;

This comment has been minimized.

@yuyuyu101
@@ -198,7 +198,7 @@ class C_drain : public EventCallback {
void NetworkStack::drain()
{
ldout(cct, 10) << __func__ << " started." << dendl;
ldout(cct, 21) << __func__ << " started." << dendl;

This comment has been minimized.

@yuyuyu101

This comment has been minimized.

@wjwithagen

wjwithagen Apr 21, 2017

Contributor

@yuyuyu101
I set these all to 21 to just get them out of the "regular" full debug mode.
But 30 is fine with me as well.
Will fix

msg/async/EventKqueue.cc: set logging from Kqueue higher
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Apr 21, 2017

retest please

@yuyuyu101 yuyuyu101 merged commit 66e68b3 into ceph:master Apr 22, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-freebsd-kqueue-logging branch Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment