New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: dont spawn error_repo until lease is acquired #14714

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Contributor

cbodley commented Apr 21, 2017

this is a speculative fix for the memory growth observed under load in multisite data sync

Fixes: http://tracker.ceph.com/issues/19446

rgw: dont spawn error_repo until lease is acquired
if RGWDataSyncShardCR fails to acquire its lease, it doesn't call
error_repo->finish() to stop the coroutine. wait until the lease
succeeds before spawning the error_repo

Fixes: http://tracker.ceph.com/issues/19446

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley requested a review from yehudasa Apr 21, 2017

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 24, 2017

ping @yehudasa

@yehudasa

lgtm

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 26, 2017

jenkins test this please

1 similar comment
@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 26, 2017

jenkins test this please

@cbodley cbodley merged commit 577cca0 into ceph:master Apr 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
arm build successfully built on arm
Details
default Build finished.
Details

@cbodley cbodley deleted the cbodley:wip-19446 branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment