New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: release allocated PyString #14716

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Apr 21, 2017

Signed-off-by: Kefu Chai kchai@redhat.com

mgr: release allocated PyString
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from liewegas and jcsp Apr 21, 2017

@jcsp

jcsp approved these changes Apr 21, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 21, 2017

still seeing leaks under valgrind, so this isn't a complete solution at lesat

  0x26e
  1
  Leak_PossiblyLost
  
    38 bytes in 1 blocks are possibly lost in loss record 623 of 4,188
    38
    1
  
  
    
      0x981DBE3
      /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so
      malloc
      /builddir/build/BUILD/valgrind-3.11.0/coregrind/m_replacemalloc
      vg_replace_malloc.c
      299
    
    
      0x9AB2CCC
      /usr/lib64/libpython2.7.so.1.0
      PyObject_Malloc
    
    
      0x9AC2974
      /usr/lib64/libpython2.7.so.1.0
      PyString_FromString
    
    
      0x9A9120F
      /usr/lib64/libpython2.7.so.1.0
    
    
      0x9A91B07
      /usr/lib64/libpython2.7.so.1.0
      PyFile_FromFile
    
    
      0x9B3208A
      /usr/lib64/libpython2.7.so.1.0
      _PySys_Init
    
    
      0x9B2BF04
      /usr/lib64/libpython2.7.so.1.0
      Py_InitializeEx
    
    
      0x3410C0
      /usr/bin/ceph-mgr
      PyModules::init()
      /usr/src/debug/ceph-12.0.1-1303-gb3cd0b9/src/mgr
      PyModules.cc
      360
    
    
      0x358691
      /usr/bin/ceph-mgr
      Mgr::init()
      /usr/src/debug/ceph-12.0.1-1303-gb3cd0b9/src/mgr
      Mgr.cc
      207
    

/a/sage-2017-04-21_17:25:23-rados:verify-wip-sage-testing2---basic-smithi/1053636

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 21, 2017

no, it's not a complete fix. but we are closer, i think.

@liewegas liewegas merged commit 7b9cd85 into ceph:master Apr 21, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@tchaikov tchaikov deleted the tchaikov:wip-mgr-pystring-leak branch Apr 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment