New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: don't do crypto/isa-l if not Intel #14721

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
3 participants
@dmick
Member

dmick commented Apr 21, 2017

Signed-off-by: Dan Mick dan.mick@redhat.com

CMakeLists.txt: don't do crypto/isa-l if not Intel
Signed-off-by: Dan Mick <dan.mick@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 21, 2017

you meant #11049, i guess?

@dmick

This comment has been minimized.

Member

dmick commented Apr 21, 2017

yeah.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 21, 2017

@dmick we might want to guard "src/os/CMakeLists.txt:add_dependencies(os ceph_crypto_isal)" also.

@dmick

This comment has been minimized.

Member

dmick commented Apr 21, 2017

tchaikov: we could, but it's harmless AFAICT

@liewegas liewegas merged commit 03c5962 into ceph:master Apr 21, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@smithfarm smithfarm referenced this pull request Apr 25, 2017

Merged

Wip v12.0.2 #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment