New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/ceph.in: Use env(CEPH_DEV) to suppress noise from ceph #14746

Merged
merged 3 commits into from May 26, 2017

Conversation

Projects
None yet
2 participants
@wjwithagen
Contributor

wjwithagen commented Apr 24, 2017

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@wjwithagen wjwithagen requested a review from Apr 24, 2017

@ghost ghost removed the request for review from Apr 24, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 25, 2017

Include a patch to vstart.sh to export CEPH_DEV=1 ?

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Apr 26, 2017

@liewegas
I looked at that, but the first attempt did not really feel comfortable, but I'll look at it again.

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Apr 27, 2017

@liewegas
Hi, added it to vstart.sh absolutely since vstart is only used during testing and development.
And it is my intention to only suppress trivial log info under this flag.

Is there a location in the doc tree where to document this?

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 27, 2017

This looks good. The one additional thing I'd do is add an echo "CEPH_DEV=1" line to teh end of vstart.sh. (The idea is a dev can paste this back into their terminal after running vstart to get their environment to behave.)

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Apr 28, 2017

@liewegas
Also deleted a set -x in ceph-helper.sh, to shutdown kill_daemon noise.

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented May 3, 2017

@liewegas
Ping?

@@ -940,3 +944,6 @@ if [ "$CEPH_DIR" != "$PWD" ]; then
echo "export CEPH_CONF=$conf_fn"
echo "export CEPH_KEYRING=$keyring_fn"
fi
echo "CEPH_DEV=1 was set, you might want to unset it"

This comment has been minimized.

@liewegas

liewegas May 3, 2017

Member

just

echo "CEPH_DEV=1"

The variable doesn't affect the calling shell; these vars are all just printed out so that they are easy for the developer to cut and paste back into the terminal. (In order to set up the environment for the caller automatically we'd need to spawn a subshell, or run vstart with 'source ..' or something similarly tricky.)

@liewegas

This comment has been minimized.

Member

liewegas commented May 19, 2017

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented May 21, 2017

@liewegas
I was on vacation the last 2,5 weeks. I'll be picking up things after all unpacking is done.

wjwithagen added some commits Apr 24, 2017

src/ceph.in: Use env(CEPH_DEV) to suppress noise from ceph
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
vstart:Suppress trivial logging info during devlopment
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
./qa/workunits/ceph-helpers.sh: Do not trace kill_daemon
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented May 26, 2017

@liewegas
Had a lot of work to catch up to, so only found some time check the state of my work.
So pushed your suggestion.

@liewegas liewegas merged commit d6c4925 into ceph:master May 26, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment