New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: introduce DirectMessenger #14755

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
4 participants
@cbodley
Contributor

cbodley commented Apr 24, 2017

DirectMessenger provides an efficient mechanism to support in-process embedding of Ceph components (e.g., embedding of the Ceph OSD in storage targets such as NFSv4 or iSCSI targets).

This is the messenger used by #13336 to inject OSD operations within the same process, split out for separate review.

@cbodley cbodley requested a review from gregsfortytwo Apr 24, 2017

@liewegas liewegas added the needs-qa label Apr 24, 2017

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Apr 24, 2017

Notes from @liewegas over bluejeans: we should put it in a test directory since it's for testing.
It's good that this can't be accidentally instantiated, but let's clearly document its purpose (ie, exclusively for testing and IO injection, do not use as a model, does not complete everything).

not actually ready for merge

core: introduce DirectMessenger
DirectMessenger provides an efficient mechanism to support
in-process embedding of Ceph components (e.g., embedding of the
Ceph OSD in storage targets such as NFSv4 or iSCSI targets).

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 25, 2017

  • moved src/msg/direct to src/test/direct_messenger
  • moved unit test into src/test/direct_messenger
  • added text to block comment in DirectMessenger.h:
 * This is for testing and i/o injection only, and cannot be used
 * for normal messengers with ms_type.
@liewegas

This comment has been minimized.

Member

liewegas commented Apr 25, 2017

@gregsfortytwo ready for merge?

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 25, 2017

retest this please

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Apr 25, 2017

Yep, we just finished discussing this verbally.

@gregsfortytwo

Reviewed-by: Greg Farnum gfarnum@redhat.com
Reviewed-by: Sage Weil sage@redhat.com

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Apr 25, 2017

Sadly the fio integration stuff will reportedly take a bit more work. :(

@yuriw

This comment has been minimized.

Contributor

yuriw commented Apr 25, 2017

test this please

@yuriw yuriw merged commit 024314e into ceph:master Apr 25, 2017

3 of 4 checks passed

arm build Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@cbodley cbodley deleted the cbodley:wip-msg-direct branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment