Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd/bench: add notes of default values, it's easy to use #14762

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
@zy751713126
Copy link
Contributor

zy751713126 commented Apr 25, 2017

Signed-off-by: Zheng Yin zhengyin@chinac.com

--io-size arg IO size (in B/K/M/G/T)
--io-threads arg ios in flight
--io-total arg total size for IO (in B/K/M/G/T)
--io-size arg IO size (in B/K/M/G/T) [default: 4096B]

This comment has been minimized.

Copy link
@trociny

trociny Apr 25, 2017

Contributor

nit: may be '4K'?

This comment has been minimized.

Copy link
@zy751713126

zy751713126 Apr 25, 2017

Author Contributor

yes

This comment has been minimized.

Copy link
@zy751713126

zy751713126 Apr 25, 2017

Author Contributor

yes

--io-total arg total size for IO (in B/K/M/G/T)
--io-size arg IO size (in B/K/M/G/T) [default: 4096B]
--io-threads arg ios in flight [default: 16]
--io-total arg total size for IO (in B/K/M/G/T) [default: 1G]
--io-pattern arg IO pattern (rand or seq)
--io-type arg IO type (read or write)

This comment has been minimized.

Copy link
@trociny

trociny Apr 25, 2017

Contributor

I would add default descriptions for IO pattern and IO type too.

This comment has been minimized.

Copy link
@zy751713126

zy751713126 Apr 25, 2017

Author Contributor

Default description for IO pattern is seq, I will add it. But IO type has no default description.

This comment has been minimized.

Copy link
@trociny

trociny Apr 25, 2017

Contributor

Agreed. I thought it was write by default.

@zy751713126 zy751713126 force-pushed the zy751713126:add-bench-notes branch from fae9677 to 4a72bb2 Apr 25, 2017

rbd/bench: add notes of default values, it's more easy to use
Signed-off-by: Zheng Yin <zhengyin@chinac.com>

@zy751713126 zy751713126 force-pushed the zy751713126:add-bench-notes branch from 4a72bb2 to 79b6695 Apr 25, 2017

@yangdongsheng

This comment has been minimized.

Copy link
Member

yangdongsheng commented Apr 25, 2017

Looks good.

@trociny trociny merged commit dba3de2 into ceph:master Apr 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@zy751713126 zy751713126 deleted the zy751713126:add-bench-notes branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.