New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: rpm: package crypto on x86_64 only #14779

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Apr 25, 2017

ca40e12 added the following lines to the spec
file:

%dir %{_libdir}/ceph/crypto
%{_libdir}/ceph/crypto/libceph_*.so*

and 3509329 made it so those build artifacts
are generated on x86_64 only.

The result is a build failure on non-x86_64 architectures:

error: Directory not found: /home/abuild/rpmbuild/BUILDROOT/ceph-12.0.2+git.1493119152.181baf6-1.1.ppc64le/usr/lib64/ceph/crypto
error: File not found by glob: /home/abuild/rpmbuild/BUILDROOT/ceph-12.0.2+git.1493119152.181baf6-1.1.ppc64le/usr/lib64/ceph/crypto/libceph_*.so*

Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Apr 25, 2017

I can include an analogous change in debian/ if someone tells me how to do it . . .

@smithfarm smithfarm changed the title from build/ops: package crypto on x86_64 only to build/ops: rpm: package crypto on x86_64 only Apr 25, 2017

build/ops: rpm: package crypto on x86_64 only
ca40e12 added the following lines to the spec
file:

%dir %{_libdir}/ceph/crypto
%{_libdir}/ceph/crypto/libceph_*.so*

and 3509329 made it so those build artifacts
are generated on x86_64 only.

The result is a build failure on non-x86_64 architectures:

error: Directory not found: /home/abuild/rpmbuild/BUILDROOT/ceph-12.0.2+git.1493119152.181baf6-1.1.ppc64le/usr/lib64/ceph/crypto
error: File not found by glob: /home/abuild/rpmbuild/BUILDROOT/ceph-12.0.2+git.1493119152.181baf6-1.1.ppc64le/usr/lib64/ceph/crypto/libceph_*.so*

Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm referenced this pull request Apr 25, 2017

Merged

Wip v12.0.2 #103

@@ -929,8 +929,10 @@ rm -rf %{buildroot}
%{_libdir}/ceph/erasure-code/libec_*.so*
%dir %{_libdir}/ceph/compressor
%{_libdir}/ceph/compressor/libceph_*.so*
%ifarch x86_64

This comment has been minimized.

@tchaikov

tchaikov Apr 25, 2017

Contributor

we have

usr/lib/ceph/crypto/*

in ceph-common.install. it concerns me if dpkg-buildpackage could complain at seeing an non-existant directory. i will test/RTFM and come back to you.

@tchaikov tchaikov added the needs-qa label Apr 26, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Apr 26, 2017

This fixes the arch builds (and does not break the x86_64 build) in OBS.

Pushed to ceph-ci to reaffirm that all is OK: https://shaman.ceph.com/builds/ceph/wip-fix-arch-build/4b79ac9a72c2ea71955fa6104f46818552b7a0b5/

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 26, 2017

just fyi, pushed to ceph/ceph-ci as wip-14779-kefu for testing the debian packaging.

@smithfarm

This comment has been minimized.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 27, 2017

@tchaikov tchaikov merged commit bdcc25b into ceph:master Apr 27, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
arm build successfully built on arm
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 27, 2017

@smithfarm the debian fix is posted at #14820.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment