Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: recognize exclusive option #14785

Merged
merged 2 commits into from Apr 26, 2017

Conversation

Projects
None yet
2 participants
@idryomov
Copy link
Contributor

idryomov commented Apr 25, 2017

No description provided.

@idryomov

This comment has been minimized.

rbd: recognize exclusive map option
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

@idryomov idryomov force-pushed the idryomov:wip-krbd-exclusive-option branch from 207afae to 2a69baa Apr 25, 2017

python -m json.tool)"

local expected
expected="$(cat <<EOF

This comment has been minimized.

Copy link
@trociny

trociny Apr 26, 2017

Contributor

Just a suggestion to change this to

expected="$(cat <<EOF | python -m json.tool

i.e. to filter it with json.tool similarly to actual, just in case space formatting depends on json.tool version.

qa/workunits/rbd: test exclusive map option
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

@idryomov idryomov force-pushed the idryomov:wip-krbd-exclusive-option branch from 2a69baa to 192f6ca Apr 26, 2017

@idryomov

This comment has been minimized.

@trociny
Copy link
Contributor

trociny left a comment

lgtm

@idryomov idryomov merged commit 9038074 into ceph:master Apr 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
arm build successfully built on arm
Details
default Build finished.
Details

@idryomov idryomov deleted the idryomov:wip-krbd-exclusive-option branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.