New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixing assert that creates warning: comparison between signed and unsigned integer expressions #14794

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
3 participants
@joscollin
Member

joscollin commented Apr 26, 2017

This fixes the additional comments in the PR: #14705

Signed-off-by: Jos Collin jcollin@redhat.com

@joscollin

This comment has been minimized.

Member

joscollin commented Apr 26, 2017

@badone @tchaikov @chardan Requesting all of you to review this and provide your comments.

@@ -46,8 +46,7 @@ TEST(SimpleSpin, Test1)
// Should also work with pass-by-reference:
// (Note that we don't care about cross-threading here as-such.)
counter = 0;
uint32_t urhs = 0;
ASSERT_EQ(counter, urhs);
ASSERT_EQ(0u, counter);

This comment has been minimized.

@badone

badone Apr 26, 2017

Contributor

The order of the args to ASSERT_EQ throughout the file is now inconsistent. I would make them all consistent (correct order) and, as previously mentioned, I would probably drop this particular line because it is unnecessary.

@chardan

+1

@badone

This comment has been minimized.

Contributor

badone commented Apr 26, 2017

Can you merge your two commits?

test: fixing assert that creates warning: comparison between signed a…
…nd unsigned integer expressions

This fixes the additional comments in the PR: #14705
Fixed the review comments too.

Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin

This comment has been minimized.

Member

joscollin commented Apr 27, 2017

@badone Done.

@badone

badone approved these changes Apr 27, 2017

@badone badone merged commit 01625a9 into ceph:master Apr 28, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
arm build successfully built on arm
Details
default Build finished.
Details

@badone badone removed the needs-qa label Apr 28, 2017

@joscollin joscollin deleted the joscollin:wip-warning-simplespin branch Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment