New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: various cleanups #14802

Merged
merged 3 commits into from Apr 27, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Apr 26, 2017

No description provided.

tchaikov added some commits Apr 26, 2017

cmake: no need to link ceph-mgr against mds
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr: pass python interpreter's path to embedded python
* also do prevent python from registering its own signal handler, it does
  not make sense in our embedded use case.
* pass python interpreter's path to embedded python before initializing
  it. python uses this path to look up the "site" modules, etc.

so it can use other interpreter if it is not intalled into $PATH,
otherwise the "python" in $PATH will always be used even the
PYTHON_EXECUTABLE in CMake's cache is pointing to another python
interpreter.

if one want to debug ceph-mgr with a customize build python, this would
be helpful.

Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/MgrPyModule: no need to keep pClass and pModule around
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from liewegas and jcsp Apr 26, 2017

@liewegas liewegas merged commit 40699a6 into ceph:master Apr 27, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@tchaikov tchaikov deleted the tchaikov:wip-mgr-cleanup branch Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment