New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: show inactive % in ceph status #14810

Merged
merged 3 commits into from May 2, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Apr 26, 2017

Include a message like "1.232% pgs inactive" in status display when appropriate. This
avoids the usual mental arithmetic that happens while waiting for the cluster to recover,
and parallels the degraded and misplaced counts (on objects).

liewegas added some commits Apr 26, 2017

mon/PGMap: inline init for a few fields
Signed-off-by: Sage Weil <sage@redhat.com>
mon/PGMap: track active pgs
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from tchaikov Apr 27, 2017

@tchaikov

aside from the indent, lgtm

} else {
char b[20];
snprintf(b, sizeof(b), "%.3lf", (1.0 - p) * 100.0);
*out << " " << b << "% pgs inactive\n";

This comment has been minimized.

@tchaikov

tchaikov Apr 28, 2017

Contributor

wrong indent.

This comment has been minimized.

@liewegas

liewegas Apr 28, 2017

Member

fixed!

@tchaikov tchaikov added the needs-qa label Apr 28, 2017

mon/PGMap: include pgs inactive % in summary
Signed-off-by: Sage Weil <sage@redhat.com>

@yuriw yuriw merged commit 3dbc29b into ceph:master May 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment