New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/rgw: fix for empty lists as default arguments #14816

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Contributor

cbodley commented Apr 26, 2017

i was incorrectly using [] as a default function argument, without
realizing that default values are mutable and shared across invocations

test/rgw: fix for empty lists as default arguments
i was incorrectly using [] as a default function argument, without
realizing that default values are mutable and shared across invocations

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley added rgw tests labels Apr 26, 2017

@cbodley cbodley requested a review from yehudasa Apr 27, 2017

@yehudasa

lgtm

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 27, 2017

@yehudasa could you please review? this wasn't causing test failures, but it was causing the calls to z3.stop() and z3.start() in test_multi_period_incremental_sync() to stop and restart the gateways in -all- zones, rather than just zone 3. this is because all of the zones were 'sharing' the same list of gateways due to Zone's constructor defaulting to gateways = []

@cbodley cbodley merged commit bac49f3 into ceph:master Apr 27, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
arm build successfully built on arm
Details
default Build finished.
Details

@cbodley cbodley deleted the cbodley:wip-rgw-test-multi-list-fix branch Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment