Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: package crypto plugin only on amd64 #14820

Merged
merged 2 commits into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

tchaikov commented Apr 27, 2017

No description provided.

cmake: os should depend on crypto_plugins not a certain plugin
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from dmick, cbodley and smithfarm Apr 27, 2017

@tchaikov tchaikov force-pushed the tchaikov:wip-deb-maint-fun branch from bb68d8a to 9d4cf21 Apr 27, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Apr 27, 2017

pushed to ceph/ceph-ci as wip-14820-kefu for testing using shaman.

@smithfarm
Copy link
Contributor

smithfarm left a comment

OK if it passes Shaman

debian: package crypto plugins only on amd64
currently, only plugin based on isa-l is installed. archs other than
amd64 will not have this directory or the plugin(s) residing in it.
hence dh_install will fail when trying to copy nonexistence file/dir.

* debian/ceph-common.install: chmod +x, and only install crypto on amd64
  so dh_install can filter the install list using dh-exec
* debian/control: depends on dh-exec now. dh-exec v0.13 introduces support
  for filtering based on architecture. see dh-exec's changelog for more
  details. but trusty only offers dh-exec v0.12. so do not require ">=
  0.13) at this moment.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-deb-maint-fun branch from 9d4cf21 to cd4dbae Apr 27, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Apr 27, 2017

changelog

  • do not require "dh-exec (>= 0.13)" to cater the trusty build.
The following packages have unmet dependencies:
 pbuilder-satisfydepends-dummy : Depends: dh-exec (>= 0.13) but it is not going to be installed.

see http://packages.ubuntu.com/trusty/dh-exec and https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=trusty,DIST=trusty,MACHINE_SIZE=huge/2891//consoleFull

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Apr 27, 2017

@tchaikov tchaikov merged commit 60d95d4 into ceph:master Apr 27, 2017

3 of 4 checks passed

default Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
arm build successfully built on arm
Details

@tchaikov tchaikov deleted the tchaikov:wip-deb-maint-fun branch Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.