Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fs/ceph-fuse: normalize file open flags on the wire #14822
Sorry that was a bit hasty. My assumption is that flags from a client message will never be used for MDS-local file io. So there is no need to pay attention to when the normalized CEPH_O_* flags are used vs the O_* flags of the MDS' architecture. We can simply use CEPH_O_* across the board and don't do any conversion from CEPH_O_* to the whatever the architecture defines as O_*.
Just trying to make sure my assumption is correct.
For RADOS, I believe that's true. (Of course, the MDS doesn't do any local file IO for client req)
That would be correct.
Just one small holdout: https://github.com/ceph/ceph/pull/14822/files#diff-eecf840e09d7481f7b8f415789852c7dR2949
and the same in openc. Now that I see where
ceph_flags_to_mode is defined in
include/ceph_fs.h, it would be good to move your Client
ceph_fs.h, and adjust the
ceph_flags_to_mode function to use your new