New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: do shutdown using finisher so we can do it in the right order #14835

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Apr 27, 2017

otherwise we can shutdown a PyModules while it still being init'ed

Fixes: http://tracker.ceph.com/issues/19743
Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested review from liewegas and jcsp Apr 27, 2017

@tchaikov tchaikov changed the title from mgr: do shutdown using finisher so we can do it in the right order to [DNM] mgr: do shutdown using finisher so we can do it in the right order Apr 27, 2017

@tchaikov tchaikov removed request for liewegas and jcsp Apr 27, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 27, 2017

lgtm

mgr: do shutdown using finisher so we can do it in the right order
otherwise we can shutdown a PyModules while it still being init'ed

Fixes: http://tracker.ceph.com/issues/19743
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 27, 2017

changelog:

  • do not schedule module->shutdown() in finisher, we are already in finisher!

@tchaikov tchaikov changed the title from [DNM] mgr: do shutdown using finisher so we can do it in the right order to mgr: do shutdown using finisher so we can do it in the right order Apr 27, 2017

@tchaikov tchaikov requested review from liewegas and jcsp Apr 27, 2017

@liewegas liewegas added the needs-qa label Apr 27, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 27, 2017

retest this please

@yuriw yuriw merged commit 75c1818 into ceph:master Apr 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-19743 branch Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment